siddharthteotia commented on a change in pull request #7214:
URL: https://github.com/apache/pinot/pull/7214#discussion_r681437075
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java
##########
@@ -345,7 +373,11 @@ public void testTextSearch()
"SELECT INT_COL, SKILLS_TEXT_COL FROM MyTable WHERE
TEXT_MATCH(SKILLS_TEXT_COL, '\"Machine learning\"') LIMIT 50000";
testTextSearchSelectQueryHelper(query, expected.size(), false, expected);
- query = "SELECT COUNT(*) FROM MyTable WHERE TEXT_MATCH(SKILLS_TEXT_COL,
'\"Machine learning\"') LIMIT 50000";
+ query =
+ "SELECT INT_COL, SKILLS_TEXT_COL FROM MyTable WHERE SKILLS_TEXT_COL
LIKE '\"Machine learning\"' LIMIT 50000";
+ testTextSearchSelectQueryHelper(query, expected.size(), false, expected);
+
+ query = "SELECT COUNT(*) FROM MyTable WHERE SKILLS_TEXT_COL LIKE
'\"Machine learning\"' LIMIT 50000";
Review comment:
Can you also add few more tests -- essentially a LIKE version of
majority of tests here to test out multiple phrases using boolean, regex,
prefix etc. Right now the LIKE tests are only testing single phrases I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
