Jackie-Jiang commented on a change in pull request #7231:
URL: https://github.com/apache/pinot/pull/7231#discussion_r679553054
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -1028,7 +1058,8 @@ public boolean isSingleValue() {
return this.ordinal() <= OBJECT.ordinal();
}
- public PinotDataType getSingleValueType() {
+ @VisibleForTesting
Review comment:
Let's keep it public. This can be useful
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -1057,6 +1088,16 @@ public PinotDataType getSingleValueType() {
}
}
+ public static PinotDataType getSingleValueType(Class<?> cls) {
+ PinotDataType pdt = SINGLE_VALUE_TYPE_MAP.get(cls);
+ return (pdt != null) ? pdt : OBJECT;
+ }
+
+ public static PinotDataType getMultipleValueType(Class<?> cls) {
Review comment:
```suggestion
public static PinotDataType getMultiValueType(Class<?> cls) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
