mayankshriv commented on a change in pull request #7214:
URL: https://github.com/apache/pinot/pull/7214#discussion_r677638341



##########
File path: pinot-common/src/main/antlr4/org/apache/pinot/pql/parsers/PQL2.g4
##########
@@ -78,6 +78,7 @@ predicate:
   | isClause                              # IsPredicate
   | regexpLikeClause                      # RegexpLikePredicate
   | textMatchClause                       # TextMatchPredicate
+  | likeClause                            # TextMatchPredicate

Review comment:
       +1. I'd suggest that hook up the `LIKE` from calcite parser to use the 
right available index (eg text-index if available or default to REGEXP_LIKE if 
it doesn't). One thing I haven't looked at is if the three (SQL LIK,  
TEXT_MATCH, REGEXP_LIKE) are semantically the same.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to