jackjlli commented on a change in pull request #7173: URL: https://github.com/apache/incubator-pinot/pull/7173#discussion_r672490885
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java ########## @@ -341,8 +406,9 @@ public String getDataDir() { } public int getSegmentCommitTimeoutSeconds() { Review comment: Right, I wrote this one because I saw some of the java docs for the methods have been adjusted but it talks about the other way around. So mention it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org