suddendust opened a new pull request #7173:
URL: https://github.com/apache/incubator-pinot/pull/7173
## Description
#7156
This PR deprecates certain controller configurations in favour of new
configs that accept human-readable period strings.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes
Does this PR otherwise need attention when creating release notes?
* [x] Yes
## Release Notes
The following configurations have been updated. The ones to the left of the
`-> ` have been deprecated. Each deprecated configuration has been replaced
with the corresponding configuration to the right of the `-> `. If both configs
are present, the new one is picked. If both configs are present but the new
config uses an incorrect representation of period string, an exception is
thrown (it does not fallback to the old configuration).
- `controller.retention.frequencyInSeconds` ->
`controller.retention.frequencyPeriod`
- `controller.offline.segment.interval.checker.frequencyInSeconds` ->
`controller.offline.segment.interval.checker.frequencyPeriod`
- `controller.realtime.segment.validation.frequencyInSeconds` ->
`controller.realtime.segment.validation.frequencyPeriod`
- `controller.realtime.segment.validation.initialDelayInSeconds` ->
`controller.realtime.segment.validation.initialDelayPeriod`
- `controller.broker.resource.validation.frequencyInSeconds` ->
`controller.broker.resource.validation.frequencyPeriod`
- `controller.broker.resource.validation.initialDelayInSeconds` ->
`controller.broker.resource.validation.initialDelayPeriod`
- `controller.statuschecker.frequencyInSeconds` ->
`controller.statuschecker.frequencyPeriod`
- `controller.statuschecker.waitForPushTimeInSeconds` ->
`controller.statuschecker.waitForPushTimePeriod`
- `controller.task.frequencyInSeconds` -> `controller.task.frequencyPeriod`
- `controller.minion.instances.cleanup.task.frequencyInSeconds` ->
`controller.minion.instances.cleanup.task.frequencyPeriod`
- `controller.minion.instances.cleanup.task.initialDelaySeconds` ->
`controller.minion.instances.cleanup.task.initialDelayPeriod`
-
`controller.minion.instances.cleanup.task.minOfflineTimeBeforeDeletionSeconds`
-> `controller.minion.instances.cleanup.task.minOfflineTimeBeforeDeletionPeriod`
- `controller.minion.task.metrics.emitter.frequencyInSeconds` ->
`controller.minion.task.metrics.emitter.frequencyPeriod`
- `controller.segment.relocator.frequencyInSeconds` ->
`controller.segment.relocator.frequencyPeriod`
- `controller.segment.level.validation.intervalInSeconds` ->
`controller.segment.level.validation.intervalPeriod`
- `controller.statusChecker.initialDelayInSeconds` ->
`controller.statusChecker.initialDelayPeriod`
- `controller.retentionManager.initialDelayInSeconds` ->
`controller.retentionManager.initialDelayPeriod`
- `controller.offlineSegmentIntervalChecker.initialDelayInSeconds` ->
`controller.offlineSegmentIntervalChecker.initialDelayPeriod`
- `controller.segmentRelocator.initialDelayInSeconds` ->
`controller.segmentRelocator.initialDelayPeriod`
Some examples of updated configurations:
```
controller.segmentRelocator.initialDelayPeriod=20s
#controller.segment.level.validation.intervalPeriod=5m
```
## Documentation
Final PR for docs update will be raised once this PR is approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
