snleee commented on a change in pull request #7158: URL: https://github.com/apache/incubator-pinot/pull/7158#discussion_r669342288
########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/timehandler/TimeHandlerConfig.java ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.segment.processing.timehandler; + +/** + * Config for TimeHandler. + */ +public class TimeHandlerConfig { + private final TimeHandler.Type _type; + private final long _startTimeMs; + private final long _endTimeMs; + + // For EPOCH handler + private final long _roundBucketMs; Review comment: Can you add a bit more documentation around `roundBucketMs` and `partitionBucketMs`? Should we add `period` to the variable name? It seems that those 2 values are bucket size (time period). ########## File path: pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtime_to_offline_segments/RealtimeToOfflineSegmentsTaskExecutor.java ########## @@ -132,67 +130,66 @@ public void preProcess(PinotTaskConfig pinotTaskConfig) { String offlineTableName = TableNameBuilder.OFFLINE.tableNameWithType(rawTableName); TableConfig tableConfig = getTableConfig(offlineTableName); Schema schema = getSchema(offlineTableName); - Set<String> schemaColumns = schema.getPhysicalColumnNames(); String timeColumn = tableConfig.getValidationConfig().getTimeColumnName(); DateTimeFieldSpec dateTimeFieldSpec = schema.getSpecForTimeColumn(timeColumn); Preconditions .checkState(dateTimeFieldSpec != null, "No valid spec found for time column: %s in schema for table: %s", timeColumn, offlineTableName); + SegmentProcessorConfig.Builder segmentProcessorConfigBuilder = + new SegmentProcessorConfig.Builder().setTableConfig(tableConfig).setSchema(schema); - long windowStartMs = Long.parseLong(configs.get(MinionConstants.RealtimeToOfflineSegmentsTask.WINDOW_START_MS_KEY)); - long windowEndMs = Long.parseLong(configs.get(MinionConstants.RealtimeToOfflineSegmentsTask.WINDOW_END_MS_KEY)); + long windowStartMs = Long.parseLong(configs.get(RealtimeToOfflineSegmentsTask.WINDOW_START_MS_KEY)); + long windowEndMs = Long.parseLong(configs.get(RealtimeToOfflineSegmentsTask.WINDOW_END_MS_KEY)); _nextWatermark = windowEndMs; - String timeColumnTransformFunction = Review comment: Removing `TIME_COLUMN_TRANSFORM_FUNCTION` means that RealtimeToOffline task is not backward compatible after this change. Two options: 1. Add deprecated annotation & keep the backward compatibility instead of removing this 2. Remove this and include it in the release note ########## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/timehandler/TimeHandler.java ########## @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.segment.processing.timehandler; + +import javax.annotation.Nullable; +import org.apache.pinot.spi.data.readers.GenericRow; + + +/** + * Handler for time values within the records: + * - Filter records based on the start/end time range + * - Round time values (for ROLLUP and DEDUP mode) Review comment: Can you briefly explain why `DEDUP` needs rounding? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
