Jackie-Jiang opened a new pull request #7127: URL: https://github.com/apache/incubator-pinot/pull/7127
## Description Relate to #7064 - Fix `LeadControllerManager` and `ControllerLeadLocator` to properly handle the custom instance id for the controller. Currently these 2 classes assume that the Helix controller instance id is of the format `<hostname>_<port>` and the Helix participant instance id is of the format `Controller_<hostname>_<port>`. - Enforce custom instance id for controller/broker/minion to follow the instance type prefix convention because the prefix is used to determine the instance type. - Log warning for server custom instance id that does not follow the instance type prefix (not throwing exception for backward compatibility) ## Upgrade Notes In order to use custom controller instance id, servers must have been deployed with the new code because it relies on the fix in `ControllerLeadLocator` to read the lead controller hostname and port ## Release Notes The custom instance id should follow the instance type prefix convention: - Controller: `Controller_` - Broker: `Broker_` - Server: `Server_` - Minion: `Minion_` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
