[incubator-pinot] branch master updated: Validate the length of preprocessing operation from custom config (#7119)

[jlli]

This is an automated email from the ASF dual-hosted git repository.

jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 423ac35  Validate the length of preprocessing operation from custom 
config (#7119)
423ac35 is described below

commit 423ac354bb8d318fb308324a644164bd076bf663
Author: Jialiang Li <j...@linkedin.com>
AuthorDate: Thu Jul 1 19:41:40 2021 -0700

    Validate the length of preprocessing operation from custom config (#7119)
    
    Co-authored-by: Jack Li(Analytics Engineering) <j...@jlli-mn1.linkedin.biz>
---
 .../pinot/hadoop/utils/preprocess/DataPreprocessingUtils.java     | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git 
a/pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/utils/preprocess/DataPreprocessingUtils.java
 
b/pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/utils/preprocess/DataPreprocessingUtils.java
index bf399af..4cc6f75 100644
--- 
a/pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/utils/preprocess/DataPreprocessingUtils.java
+++ 
b/pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/utils/preprocess/DataPreprocessingUtils.java
@@ -75,12 +75,14 @@ public class DataPreprocessingUtils {
     }
   }
 
-  public static Set<Operation> getOperations(Set<Operation> operationSet, 
String preprocessingOperationsString) {
+  public static void getOperations(Set<Operation> operationSet, String 
preprocessingOperationsString) {
     String[] preprocessingOpsArray = preprocessingOperationsString.split(",");
     for (String preprocessingOps : preprocessingOpsArray) {
-      
operationSet.add(Operation.getOperation(preprocessingOps.trim().toUpperCase()));
+      String trimmedOps = preprocessingOps.trim().toUpperCase();
+      if (!trimmedOps.isEmpty()) {
+        operationSet.add(Operation.getOperation(trimmedOps));
+      }
     }
-    return operationSet;
   }
 
   public enum Operation {

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org