This is an automated email from the ASF dual-hosted git repository.

mcvsubbu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new bbdd615  Added support for additional mvn options (#7103)
bbdd615 is described below

commit bbdd6151b8c6b596621addf1ae06e779c4009006
Author: Subbu Subramaniam <mcvsu...@users.noreply.github.com>
AuthorDate: Tue Jun 29 13:11:40 2021 -0700

    Added support for additional mvn options (#7103)
    
    Additional options (e.g. proxy settings) can be passed for maven build 
commands
    in firewalled environments
---
 compatibility-verifier/checkoutAndBuild.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/compatibility-verifier/checkoutAndBuild.sh 
b/compatibility-verifier/checkoutAndBuild.sh
index 47eb4ae..bc79422 100755
--- a/compatibility-verifier/checkoutAndBuild.sh
+++ b/compatibility-verifier/checkoutAndBuild.sh
@@ -35,6 +35,8 @@ function usage() {
   echo -e "    To compare this checkout with previous commit: '${cmdName} -w 
/tmp/wd'"
   echo -e "    To compare this checkout with some older tag or hash: 
'${cmdName} -o release-0.7.1 -w /tmp/wd'"
   echo -e "    To compare any two previous tags or hashes: '${cmdName} -o 
release-0.7.1 -n 637cc3494 -w /tmp/wd"
+  echo -e "Environment:"
+  echo -e "    Additional maven build options can be passed in via environment 
varibale MAVEN_OPTS"
   exit 1
 }
 
@@ -50,7 +52,7 @@ function checkoutAndBuild() {
   # Pull the tag list so that we can check out by tag name
   git fetch --tags || exit 1
   git checkout $commitHash || exit 1
-  mvn install package -DskipTests -Pbin-dist -T 4 -Djdk.version=8 || exit 1
+  mvn install package -DskipTests -Pbin-dist -T 4 -Djdk.version=8 
${MAVEN_OPTS} || exit 1
   popd || exit 1
   exit 0
 }
@@ -117,7 +119,7 @@ workingDir=$(absPath "$workingDir")
 newTargetDir="$workingDir"/newTargetDir
 if [ -z "$newerCommit" ]; then
   echo "Compiling current tree as newer version"
-  (cd $cmdDir/.. && mvn install package -DskipTests -Pbin-dist -T 4 -D 
jdk.version=8 && mvn -pl pinot-tools package -T 4 -DskipTests -Djdk.version=8 
&& mvn -pl pinot-integration-tests package -T 4 -DskipTests -Djdk.version=8)
+  (cd $cmdDir/.. && mvn install package -DskipTests -Pbin-dist -T 4 -D 
jdk.version=8 ${MAVEN_OPTS} && mvn -pl pinot-tools package -T 4 -DskipTests 
-Djdk.version=8 ${MAVEN_OPTS} && mvn -pl pinot-integration-tests package -T 4 
-DskipTests -Djdk.version=8 ${MAVEN_OPTS})
   if [ $? -ne 0 ]; then
     echo Compile failed.
     exit 1

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to