dongxiaoman commented on a change in pull request #7064:
URL: https://github.com/apache/incubator-pinot/pull/7064#discussion_r659915596
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java
##########
@@ -53,9 +54,7 @@ public HelixBrokerStarter(PinotConfiguration brokerConf,
String clusterName, Str
private static PinotConfiguration applyBrokerConfigs(PinotConfiguration
brokerConf, String clusterName, String zkServers, @Nullable String brokerHost) {
brokerConf.setProperty(Helix.CONFIG_OF_CLUSTER_NAME, clusterName);
brokerConf.setProperty(Helix.CONFIG_OF_ZOOKEEPR_SERVER, zkServers);
- if (brokerHost == null) {
- brokerConf.clearProperty(Broker.CONFIG_OF_BROKER_HOSTNAME);
- } else {
+ if (!Strings.isNullOrEmpty(brokerHost)) {
Review comment:
Based on code reading, I don't see a use case that we need to clear the
values. cc @Jackie-Jiang for double checking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
