mayankshriv opened a new pull request #7089: URL: https://github.com/apache/incubator-pinot/pull/7089
## Description The existing implementation hard-coded the packages to be scanned for `TableConfigTuners`. As a result, users may not be able to hookup any custom tuners. In this PR, we make the following changes to fix this problem: - Make the TableConfigTunerRegistry be initialized via an explicit call from `ControllerStarter`, as opposed to class-loading time. - Replace the hardcoded package name with argument to the init() method. - The `init()` method will be called from `ControllerStarter`, which will read any user specified packages via the config `controller.table.config.tuner.packages`. - The default value for the config still remains to be `org.apache.pinot`, as in the existing code. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR fix a zero-downtime upgrade introduced earlier? * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes) Does this PR otherwise need attention when creating release notes? Things to consider: - New configuration options - Deprecation of configurations - Signature changes to public methods/interfaces - New plugins added or old plugins removed * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes) ## Release Notes <!-- If you have tagged this as either backward-incompat or release-notes, you MUST add text here that you would like to see appear in release notes of the next release. --> <!-- If you have a series of commits adding or enabling a feature, then add this section only in final commit that marks the feature completed. Refer to earlier release notes to see examples of text. --> ## Documentation <!-- If you have introduced a new feature or configuration, please add it to the documentation as well. See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
