jackjlli commented on a change in pull request #7086:
URL: https://github.com/apache/incubator-pinot/pull/7086#discussion_r657535651
##########
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseTaskExecutor.java
##########
@@ -56,4 +57,12 @@ protected Schema getSchema(String tableName) {
Preconditions.checkState(schema != null, "Failed to find schema for table:
%s", tableName);
return schema;
}
+
+ protected long getSegmentCrc(String tableNameWithType, String segmentName) {
+ OfflineSegmentZKMetadata segmentZKMetadata = ZKMetadataProvider
Review comment:
I do see some task executor like `RealtimeToOfflineSegmentsTaskExecutor`
that works on realtime segments, although it extends
`BaseMultipleSegmentsConversionExecutor`. I think it's a good practice to
eliminate all these pre-assumptions to make the code clean, in case once
`BaseSingleSegmentConversionExecutor` starts to support realtime segment in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
