siddharthteotia commented on pull request #7063: URL: https://github.com/apache/incubator-pinot/pull/7063#issuecomment-865314382
We can get this in since basis stuff is done but 2 follow-ups are must - Remove the limitation that if the column already has inverted/sorted index, we will not recommend range index on it. It is perfectly fine to have multiple indexes on the same column. We should not make the algorithm restrictive by checking for that and instead let the query pattern tell us if it is needed. - Test needs to be improved. We need to account for following cases as well -- Same column is present multiple times in the same query and different queries with =, IN and range predicates. This will anyway be needed when you add support for the above -- Same column is present multiple times in the same query and different queries with RANGE predicates to alter the weight of the predicate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
