KKcorps commented on a change in pull request #7026: URL: https://github.com/apache/incubator-pinot/pull/7026#discussion_r654778501
########## File path: pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/MessageIdStreamOffset.java ########## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.stream.pulsar; + +import java.io.IOException; +import java.nio.charset.StandardCharsets; +import org.apache.pinot.spi.stream.StreamPartitionMsgOffset; +import org.apache.pulsar.client.api.MessageId; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * {@link StreamPartitionMsgOffset} implementation for Pulsar {@link MessageId} + */ +public class MessageIdStreamOffset implements StreamPartitionMsgOffset { + private Logger LOGGER = LoggerFactory.getLogger(MessageIdStreamOffset.class); + private MessageId _messageId; + + public MessageIdStreamOffset(MessageId messageId) { + _messageId = messageId; + } + + /** + * returns the class object from string message id in the format ledgerId:entryId:partitionId + * throws {@link IOException} if message if format is invalid. + * @param messageId + */ + public MessageIdStreamOffset(String messageId) { + try { + _messageId = MessageId.fromByteArray(messageId.getBytes(StandardCharsets.UTF_8)); + } catch (IOException e) { + LOGGER.warn("Cannot parse message id " + messageId, e); Review comment: Makes sense. I was thinking at that time of returning MessageId.latest so that the consumer starts consuming from latest offset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
