mcvsubbu commented on a change in pull request #7062: URL: https://github.com/apache/incubator-pinot/pull/7062#discussion_r654042893
########## File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/HadoopSegmentPreprocessingJob.java ########## @@ -199,11 +291,31 @@ public void run() throw new RuntimeException("Job failed : " + job); } - _logger.info("Finished pre-processing job in {}ms", (System.currentTimeMillis() - startTime)); + LOGGER.info("Finished pre-processing job in {}ms", (System.currentTimeMillis() - startTime)); + } + + private void fetchPreProcessingOperations() { + _preprocessingOperations = new HashSet<>(); + TableCustomConfig customConfig = _tableConfig.getCustomConfig(); Review comment: > We should not be parsing customConfigs in open source code. They are for the site to use as they see fit. Looks like we are already using it in the hadoop module. So, go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org