Jackie-Jiang commented on pull request #7033: URL: https://github.com/apache/incubator-pinot/pull/7033#issuecomment-859090196
@jackjlli I understand why we should add the tag. My question is on when the minion fails to read the instance config (usually due to ZK or connection issue), should we abort or just blindly add the tag. With the current Helix implementation, blindly adding the tag is okay because internally it will dedup the tag, but it relies on the Helix implementation and could cause unexpected behavior if using a different Helix version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
