mapshen commented on issue #7004: URL: https://github.com/apache/incubator-pinot/issues/7004#issuecomment-853316119
@kishoreg @npawar Supposedly the offset can be added to a decoded row by modifying [1], now I have a few questions regarding the implementation details: * What would a good column name to follow our convention? `$offset` or `offset`? * Should we make it configurable or always present like the virtual columns? * Where should we define its data type when it is indexed [2]? We do this for other columns with a schema. * What index should we use for it? Raw value or sorted forward index? [1] https://github.com/apache/incubator-pinot/blob/master/pinot-plugins/pinot-stream-ingestion/pinot-kafka-base/src/main/java/org/apache/pinot/plugin/stream/kafka/KafkaJSONMessageDecoder.java#L62 [2]https://github.com/apache/incubator-pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java#L516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
