[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6977: Enhance debug endpoint for table debugging.

[GitBox]

Jackie-Jiang commented on a change in pull request #6977:
URL: https://github.com/apache/incubator-pinot/pull/6977#discussion_r641813880



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -520,8 +521,11 @@ private void processStreamEvents(MessageBatch 
messagesAndOffsets, long idlePipeS
             }
           }
         } catch (Exception e) {
-          segmentLogger.error("Caught exception while transforming the record: 
{}", decodedRow, e);
+          String errorMessage = String.format("Caught exception while 
transforming the record: {}", decodedRow);

Review comment:
       ```suggestion
             String errorMessage = String.format("Caught exception while 
transforming the record: %s", decodedRow);
   ```

##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -801,7 +812,11 @@ protected SegmentBuildDescriptor 
buildSegmentInternal(boolean forCommit) {
       try {
         FileUtils.moveDirectory(tempIndexDir, indexDir);
       } catch (IOException e) {
-        segmentLogger.error("Caught exception while moving index directory 
from: {} to: {}", tempIndexDir, indexDir, e);
+        String errorMessage =
+            String.format("Caught exception while moving index directory from: 
% to: %s", tempIndexDir, indexDir);

Review comment:
       ```suggestion
               String.format("Caught exception while moving index directory 
from: %s to: %s", tempIndexDir, indexDir);
   ```

##########
File path: 
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
##########
@@ -118,6 +119,7 @@ public void onBecomeOnlineFromConsuming(Message message, 
NotificationContext con
         segmentDataManager.goOnlineFromConsuming(metadata);
       } catch (InterruptedException e) {
         _logger.warn("State transition interrupted", e);
+        tableDataManager.addSegmentError(segmentNameStr, new 
SegmentErrorInfo(System.currentTimeMillis(), null, e));

Review comment:
       Should we put some error message?

##########
File path: 
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java
##########
@@ -166,6 +168,10 @@ public void onBecomeOnlineFromOffline(Message message, 
NotificationContext conte
       } catch (Exception e) {
         _logger.error("Caught exception in state transition from OFFLINE -> 
ONLINE for resource: {}, partition: {}",
             tableNameWithType, segmentName, e);
+        TableDataManager tableDataManager = 
_instanceDataManager.getTableDataManager(tableNameWithType);
+        if (tableDataManager != null) {
+          tableDataManager.addSegmentError(segmentName, new 
SegmentErrorInfo(System.currentTimeMillis(), null, e));

Review comment:
       Same here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org