jtao15 commented on a change in pull request #6975:
URL: https://github.com/apache/incubator-pinot/pull/6975#discussion_r641692165
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -172,7 +185,7 @@ public static URI getDeleteSegmentHttpUri(String host, int
port, String rawTable
String tableType)
throws URISyntaxException {
return new URI(StringUtil.join("/", StringUtils.chomp(HTTP + "://" + host
+ ":" + port, "/"), OLD_SEGMENT_PATH,
- rawTableName + "/" + URIUtils.encode(segmentName) + TYPE_DELIMITER +
tableType));
+ rawTableName + "/" + URIUtils.encode(segmentName) + "?" +
TYPE_DELIMITER + tableType));
Review comment:
I'm changing `TYPE_DELIMITER` because I need to use `type=` instead of
`?type=`. The current `getURI(String protocol, String host, int port, String
path)` will quote `?`, I created another `getURI()` function to get the correct
uri for start/end segment replacement api. Maybe we can merge theses two
`getURI()` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
