chenboat commented on a change in pull request #6899:
URL: https://github.com/apache/incubator-pinot/pull/6899#discussion_r634832351
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -499,6 +515,29 @@ private boolean isUpsertEnabled() {
return _upsertMode != UpsertConfig.Mode.NONE;
}
+ private boolean isPartialUpsertEnabled() {
+ return _upsertMode == UpsertConfig.Mode.PARTIAL;
+ }
+
+ private GenericRow lookupAndMerge(GenericRow incomingRow, int docId) {
Review comment:
Add tests for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
