jtao15 commented on a change in pull request #6932:
URL: https://github.com/apache/incubator-pinot/pull/6932#discussion_r634767176



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java
##########
@@ -58,8 +60,27 @@ private MinionConstants() {
   }
 
   public static class MergeRollupTask {
-    public static final String TASK_TYPE = "mergeRollupTask";
-    public static final String MERGE_TYPE_KEY = "mergeTypeKey";
+    public static final String TASK_TYPE = "MergeRollupTask";
+
+    public static final String COLLECTOR_TYPE_KEY = "collectorType";
+
+    // Rollup aggregate function related configs
+    public static final String AGGREGATE_KEY_PREFIX = "aggregate";
+
+    // Merge properties related configs
+    public static final String MERGE_KEY_PREFIX = "merge";
+    public enum Granularity {

Review comment:
       Moved this enum into `MergeRollupTaskMetadata`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to