sajjad-moradi commented on a change in pull request #6926:
URL: https://github.com/apache/incubator-pinot/pull/6926#discussion_r633900418
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimator.java
##########
@@ -430,44 +422,48 @@ private long
calculateMemoryForCompletedSegmentsPerPartition(long completedSegme
return _numSegmentsQueriedPerHost;
}
+ public void cleanup() {
Review comment:
Auto-closable will still be a public api - instead of calling .close()
directly, the object needs to be used in try with resources.
In general, I agree with sidd to hide this from the consumer of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
