siddharthteotia commented on a change in pull request #6926:
URL: https://github.com/apache/incubator-pinot/pull/6926#discussion_r633825227
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/realtime/provisioning/MemoryEstimator.java
##########
@@ -519,21 +515,23 @@ private File generateData(Date now) {
LOGGER.info("Successfully generated data file: {}", outputFile);
return outputFile;
} catch (Exception e) {
+ FileUtils.deleteQuietly(new File(outputDir));
throw new RuntimeException(e);
}
}
- private File createSegment(File csvDataFile, Date now) {
+ private File createSegment(File csvDataFile) {
// create segment
LOGGER.info("Started creating segment from file: {}", csvDataFile);
- String outDir = getOutputDir(now, "-segment");
+ String outDir = new File(_workingDir, "segment").getAbsolutePath();
SegmentGeneratorConfig segmentGeneratorConfig =
getSegmentGeneratorConfig(csvDataFile, outDir);
SegmentIndexCreationDriver driver = new SegmentIndexCreationDriverImpl();
try {
driver.init(segmentGeneratorConfig);
driver.build();
} catch (Exception e) {
+ FileUtils.deleteQuietly(new File(outDir));
Review comment:
Will this ensure that the outDir will be force deleted even if it is
non-empty? If the generation fails mid-way, it will be non-empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
