kriti-sc commented on a change in pull request #6873:
URL: https://github.com/apache/incubator-pinot/pull/6873#discussion_r633055126
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/api/resources/SegmentMetadataFetcher.java
##########
@@ -62,24 +76,63 @@ public static String getSegmentMetadata(SegmentDataManager
segmentDataManager, L
columnSet = new HashSet<>(columns);
}
ObjectNode segmentMetadataJson = (ObjectNode)
segmentMetadata.toJson(columnSet);
- segmentMetadataJson.set("indexes",
JsonUtils.objectToJsonNode(getIndexesForSegmentColumns(segmentDataManager)));
+ segmentMetadataJson.set(COLUMN_INDEX_KEY,
JsonUtils.objectToJsonNode(getIndexesForSegmentColumns(segmentDataManager)));
+ segmentMetadataJson.set(STAR_TREE_INDEX_KEY,
JsonUtils.objectToJsonNode((getStartreeIndexForSegmentColumns(segmentDataManager))));
return JsonUtils.objectToString(segmentMetadataJson);
}
+ /**
+ * Get the JSON object containing star tree index details for a segment.
+ */
+ private static List<Map<String, Object>>
getStartreeIndexForSegmentColumns(SegmentDataManager segmentDataManager) {
Review comment:
This is done.
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/api/resources/SegmentMetadataFetcher.java
##########
@@ -62,24 +76,63 @@ public static String getSegmentMetadata(SegmentDataManager
segmentDataManager, L
columnSet = new HashSet<>(columns);
}
ObjectNode segmentMetadataJson = (ObjectNode)
segmentMetadata.toJson(columnSet);
- segmentMetadataJson.set("indexes",
JsonUtils.objectToJsonNode(getIndexesForSegmentColumns(segmentDataManager)));
+ segmentMetadataJson.set(COLUMN_INDEX_KEY,
JsonUtils.objectToJsonNode(getIndexesForSegmentColumns(segmentDataManager)));
+ segmentMetadataJson.set(STAR_TREE_INDEX_KEY,
JsonUtils.objectToJsonNode((getStartreeIndexForSegmentColumns(segmentDataManager))));
return JsonUtils.objectToString(segmentMetadataJson);
}
+ /**
+ * Get the JSON object containing star tree index details for a segment.
+ */
+ private static List<Map<String, Object>>
getStartreeIndexForSegmentColumns(SegmentDataManager segmentDataManager) {
+ List<Map<String, Object>> startreeDetails = new ArrayList<>();
+ ImmutableSegmentDataManager immutableSegmentDataManager =
(ImmutableSegmentDataManager) segmentDataManager;
+ ImmutableSegment immutableSegment =
immutableSegmentDataManager.getSegment();
+ List<StarTreeV2> starTrees = immutableSegment.getStarTrees();
+ if (starTrees == null) {
+ return startreeDetails;
+ }
+ startreeDetails = getImmutableSegmentStartreeIndexes(starTrees);
+ return startreeDetails;
Review comment:
This is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
