mayankshriv opened a new pull request #6919:
URL: https://github.com/apache/incubator-pinot/pull/6919
In QuickStart, we start all Pinot components in a single JVM. And the
existing
log4j2 config for it directs package specific logs to different components.
This is broken because packages can be shared across components (eg
pinot-core).
During debugging recent problems reported in OSS, we found that realtime
consumption would stop in Pinot, but no errors/exceptions would appear in
the logs. This was due to the fact that the exceptions were thrown by
packages
that were not part of any component's log, and were missed.
In this PR we address the problem as:
- We create a single log file (logs/pinot-quickstart.log) with log level
`info` for quick-start, as it
starts all components in single JVM.
- We set the log level to error for console.
## Description
<!-- Add a description of your PR here.
A good description should include pointers to an issue or design document,
etc.
-->
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete
the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and
complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to
consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and
complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of
the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to
the documentation as well.
See
https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
