mcvsubbu commented on a change in pull request #6916:
URL: https://github.com/apache/incubator-pinot/pull/6916#discussion_r632158816
##########
File path: compatibility-verifier/sample-test-suite/post-broker-rollback.yaml
##########
@@ -28,7 +28,19 @@ operations:
tableConfigFileName: feature-test-1.json
recordReaderConfigFileName: data/recordReaderConfig.json
segmentName: FeatureTest1_Segment6
+ - type: streamOp
+ description: publish rows to PinotRealtimeFeatureTest1Event
Review comment:
pls correct the description
##########
File path: compatibility-verifier/sample-test-suite/pre-controller-upgrade.yaml
##########
@@ -20,6 +20,12 @@
# Operations to be done.
description: Operations to be run before Controller upgrade
operations:
+ - type: tableOp
Review comment:
you need to create the table after creating the kafka topic
##########
File path: compatibility-verifier/sample-test-suite/pre-controller-upgrade.yaml
##########
@@ -33,7 +39,23 @@ operations:
tableConfigFileName: feature-test-1.json
recordReaderConfigFileName: data/recordReaderConfig.json
segmentName: FeatureTest1_Segment
+ - type: streamOp
+ description: create Kafka topic PinotRealtimeFeatureTest2Event
+ op: CREATE
+ streamConfigFileName: feature-test-2-realtime-stream-config.json
Review comment:
Make sure we have 1 partition in the stream.
##########
File path: compatibility-verifier/sample-test-suite/pre-controller-upgrade.yaml
##########
@@ -33,7 +39,23 @@ operations:
tableConfigFileName: feature-test-1.json
recordReaderConfigFileName: data/recordReaderConfig.json
segmentName: FeatureTest1_Segment
+ - type: streamOp
+ description: create Kafka topic PinotRealtimeFeatureTest2Event
+ op: CREATE
+ streamConfigFileName: feature-test-2-realtime-stream-config.json
+ - type: streamOp
+ description: publish rows to PinotRealtimeFeatureTest2Event
+ op: PRODUCE
+ streamConfigFileName: feature-test-2-realtime-stream-config.json
+ numRows: 9
Review comment:
Suggest publishing higher number of rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
