Jackie-Jiang commented on a change in pull request #6914:
URL: https://github.com/apache/incubator-pinot/pull/6914#discussion_r632136517
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java
##########
@@ -112,8 +112,14 @@ private static String parseDelimiter(TableConfig
tableConfig) {
}
}
- public static boolean isComplexTypeHandlingEnabled(TableConfig tableConfig) {
- return tableConfig.getIngestionConfig() != null &&
tableConfig.getIngestionConfig().getComplexTypeConfig() != null;
+ /**
+ * @return the complex type transformer defined table config, null if the
table config does not have the config
+ */
+ public static ComplexTypeTransformer getComplexTypeTransformer(TableConfig
tableConfig) {
Review comment:
Annotate with nullable
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java
##########
@@ -147,11 +149,12 @@ public void init(SegmentGeneratorConfig config,
RecordReader recordReader)
LOGGER.info("RecordReaderSegmentCreationDataSource is used");
dataSource = new RecordReaderSegmentCreationDataSource(recordReader);
}
- init(config, dataSource,
CompositeTransformer.getDefaultTransformer(config.getTableConfig(),
config.getSchema()));
+ init(config, dataSource,
CompositeTransformer.getDefaultTransformer(config.getTableConfig(),
config.getSchema()),
+
ComplexTypeTransformer.getComplexTypeTransformer(config.getTableConfig()));
}
public void init(SegmentGeneratorConfig config, SegmentCreationDataSource
dataSource,
- RecordTransformer recordTransformer)
+ RecordTransformer recordTransformer, ComplexTypeTransformer
complexTypeTransformer)
Review comment:
Add nullable annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
