timsants commented on a change in pull request #6885:
URL: https://github.com/apache/incubator-pinot/pull/6885#discussion_r627843839
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java
##########
@@ -275,7 +277,7 @@ public static void
singleThreadedQueryRunner(PerfBenchmarkDriverConf conf, List<
for (String query : queries) {
if (timeout > 0 && System.currentTimeMillis() - startTimeAbsolute >
timeout) {
LOGGER.warn("Timeout of {} sec reached. Aborting", timeout);
- return;
+ throw new TimeoutException("Timeout of " + timeout + " sec reached.
Aborting");
Review comment:
> the intended behavior here may be to simply run as many requests as
possible and then stopping. just a thought
Chatted with Jackie on this, he said that QueryRunner isn't really used now
so we can modify it according to our needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
