xiangfu0 commented on pull request #6872: URL: https://github.com/apache/incubator-pinot/pull/6872#issuecomment-832458592
> This may (seemingly) make tests more "stable" but we may end up with an issue where things are not closed properly, and that is not detected until some random re-use of the same port, leading to transient failures. > Am I right, or am I missing something? I think the major issue we are facing is the test framework. In reality, we won't run those multi-threaded programs in the same JVM multiple times. Also, this change will eventually make us be possible to use fork to run the integration tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
