yupeng9 commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r625405696
########## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java ########## @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.recordtransformer; + +import com.google.common.annotations.VisibleForTesting; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import javax.annotation.Nullable; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.ingestion.ComplexTypeHandlingConfig; +import org.apache.pinot.spi.data.readers.GenericRow; + + +public class ComplexTypeTransformer implements RecordTransformer { + private static final CharSequence DELIMITER = "."; + private final List<String> _collectionsToUnnest; + + public ComplexTypeTransformer(TableConfig tableConfig) { + if (tableConfig.getIngestionConfig() != null + && tableConfig.getIngestionConfig().getComplexTypeHandlingConfig() != null) { + _collectionsToUnnest = + tableConfig.getIngestionConfig().getComplexTypeHandlingConfig().getUnnestConfig() != null ? tableConfig + .getIngestionConfig().getComplexTypeHandlingConfig().getUnnestConfig() : new ArrayList<>(); + } else { + _collectionsToUnnest = new ArrayList<>(); + } + } + + @VisibleForTesting + public ComplexTypeTransformer(List<String> unnestCollections) { + _collectionsToUnnest = new ArrayList<>(unnestCollections); + Collections.sort(_collectionsToUnnest); + } + + public static boolean isComplexTypeHandlingEnabled(TableConfig tableConfig) { + if (tableConfig.getIngestionConfig() == null + || tableConfig.getIngestionConfig().getComplexTypeHandlingConfig() == null + || tableConfig.getIngestionConfig().getComplexTypeHandlingConfig().getMode() == null) { + return false; + } + return tableConfig.getIngestionConfig().getComplexTypeHandlingConfig().getMode() + != ComplexTypeHandlingConfig.Mode.NONE; + } + + @Nullable + @Override + public GenericRow transform(GenericRow record) { + flattenMap(record, new HashSet<>(record.getFieldToValueMap().keySet())); Review comment: I'm not sure how much we'll save with the level-order traversal. As it'll populate the items to another linkedlist which effectively simulate `array.close`. IMHO, the shallow copy shall be cheap enough, and the code readability is more important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
