xiangfu0 commented on a change in pull request #6839:
URL: https://github.com/apache/incubator-pinot/pull/6839#discussion_r622444347
##########
File path: kubernetes/helm/pinot/templates/broker/service-headless.yaml
##########
@@ -22,17 +22,12 @@ kind: Service
metadata:
name: {{ template "pinot.broker.headless" . }}
labels:
- app: {{ include "pinot.name" . }}
- chart: {{ include "pinot.chart" . }}
- component: {{ .Values.broker.name }}
- release: {{ .Release.Name }}
- heritage: {{ .Release.Service }}
+ {{- include "pinot.brokerLabels" . | nindent 4 }}
spec:
clusterIP: None
ports:
# [pod_name].[service_name].[namespace].svc.cluster.local
- - port: {{ .Values.broker.service.port }}
+ - name: {{ .Values.broker.service.name }}
Review comment:
just keep port here. Same for other headless services
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
