Jackie-Jiang commented on a change in pull request #6824:
URL: https://github.com/apache/incubator-pinot/pull/6824#discussion_r621658184
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -172,16 +171,16 @@ private String getDefaultBrokerId() {
}
@Override
- public BrokerResponse handleRequest(JsonNode request, @Nullable
RequesterIdentity requesterIdentity,
+ public BrokerResponseNative handleRequest(JsonNode request, @Nullable
RequesterIdentity requesterIdentity,
Review comment:
This implementation always returns `BrokerResponseNative`. Changing this
can avoid some unnecessary casting. I didn't change the interface though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
