liuchang0520 commented on a change in pull request #6778:
URL: https://github.com/apache/incubator-pinot/pull/6778#discussion_r618107823
##########
File path:
pinot-server/src/test/java/org/apache/pinot/server/api/BaseResourceTest.java
##########
@@ -76,7 +77,8 @@
protected static final String LLC_SEGMENT_NAME_FOR_UPLOAD_FAILURE =
new
LLCSegmentName(TableNameBuilder.REALTIME.tableNameWithType(TABLE_NAME), 2, 0,
System.currentTimeMillis())
.getSegmentName();
- protected static final String SEGMENT_DOWNLOAD_URL =
"testSegmentDownloadUrl";
+ protected static final String SEGMENT_DOWNLOAD_URL =
Review comment:
Previously the dummy url test case failed to catch URI.getPath()
returning the truncated path without hostname. Changed to URI.toString() (in
the above change in TableResource). Just trying to simulate the real download
url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
