[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #6829: Update presto helm chart to support pinot streaming

[GitBox]

xiangfu0 commented on a change in pull request #6829:
URL: https://github.com/apache/incubator-pinot/pull/6829#discussion_r617881333



##########
File path: kubernetes/helm/presto/values.yaml
##########
@@ -32,6 +32,7 @@ pinot:
   useDateTrunc: true
   inferDateTypeInSchema: true
   inferTimestampTypeInSchema: true
+  useStreamingForSegmentQueries: false

Review comment:
       in values.yaml, you can directly set config files:
   ```
   catalogs:
       pinot.properties: |-
           connector.name=pinot
           pinot.controller-urls=pinot-controller:9000
           pinot.controller-rest-service=pinot-controller:9000
           pinot.allow-multiple-aggregations=true
           pinot.use-date-trunc=true
           pinot.infer-date-type-in-schema=true
           pinot.infer-timestamp-type-in-schema=true
           pinot.use-streaming-for-segment-queries=true
   ```

##########
File path: kubernetes/helm/presto/templates/coordinator/configmap.yaml
##########
@@ -30,6 +30,7 @@ data:
     pinot.use-date-trunc={{ .Values.pinot.useDateTrunc }}
     pinot.infer-date-type-in-schema={{ .Values.pinot.inferDateTypeInSchema }}
     pinot.infer-timestamp-type-in-schema={{ 
.Values.pinot.inferTimestampTypeInSchema }}
+    pinot.use-streaming-for-segment-queries={{ 
.Values.pinot.useStreamingForSegmentQueries }}

Review comment:
       You can remove entire `pinot.properties`
   then add:
   ```
   {{- range $path, $config := .Values. catalogs }}
     {{ $path }}: |
   {{- tpl $config $ | nindent 4 -}}
   {{- end -}}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org