This is an automated email from the ASF dual-hosted git repository.

mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new a18fe23  Fix a resource leak in base admin command (#6827)
a18fe23 is described below

commit a18fe23b29f3d7491e6027e9e1da6b3646c270b6
Author: Benedict Jin <asdf2...@apache.org>
AuthorDate: Thu Apr 22 00:26:35 2021 +0800

    Fix a resource leak in base admin command (#6827)
---
 .../pinot/tools/admin/command/AbstractBaseAdminCommand.java      | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AbstractBaseAdminCommand.java
 
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AbstractBaseAdminCommand.java
index 678e90d..8078b7c 100644
--- 
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AbstractBaseAdminCommand.java
+++ 
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AbstractBaseAdminCommand.java
@@ -88,10 +88,11 @@ public class AbstractBaseAdminCommand extends 
AbstractBaseCommand {
     conn.setRequestMethod(requestMethod);
     conn.setDoOutput(true);
     if (payload != null) {
-      final BufferedWriter writer = new BufferedWriter(new 
OutputStreamWriter(conn.getOutputStream(),
-          StandardCharsets.UTF_8));
-      writer.write(payload, 0, payload.length());
-      writer.flush();
+      try (final BufferedWriter writer = new BufferedWriter(new 
OutputStreamWriter(conn.getOutputStream(),
+          StandardCharsets.UTF_8))) {
+        writer.write(payload, 0, payload.length());
+        writer.flush();
+      }
     }
 
     try {

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to