mayankshriv commented on a change in pull request #6826:
URL: https://github.com/apache/incubator-pinot/pull/6826#discussion_r617700212
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##########
@@ -116,7 +116,7 @@ public void removeSegment(String segmentName) {
_logger.info("Successfully removed segment {} and reloaded lookup table:
{}", segmentName, getTableName());
} catch (Exception e) {
throw new RuntimeException(String
- .format("Error reloading lookup table after segment remove ({}) for
table: {}", segmentName, getTableName()),
+ .format("Error reloading lookup table after segment remove (%s) for
table: %s", segmentName, getTableName()),
Review comment:
Thanks for finding and fixing this.
Minor nit: Fix grammar, and use single quotes around %s (I usually do that
to catch an empty string value as '').
Something like:
"Error reloading lookup table after segment '%s' removed for table: '%s'"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
