malbx commented on a change in pull request #6765: URL: https://github.com/apache/incubator-pinot/pull/6765#discussion_r614572360
########## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ########## @@ -294,7 +294,7 @@ public BrokerResponse handleRequest(JsonNode request, @Nullable RequesterIdentit if ((offlineTableName == null) && (realtimeTableName == null)) { // No table matches the request LOGGER.info("No table matches for request {}: {}", requestId, query); - requestStatistics.setErrorCode(QueryException.BROKER_RESOURCE_MISSING_ERROR_CODE); + requestStatistics.setErrorCode(QueryException.TABLE_DOES_NOT_EXIST_ERROR_CODE); _brokerMetrics.addMeteredGlobalValue(BrokerMeter.RESOURCE_MISSING_EXCEPTIONS, 1); Review comment: @Jackie-Jiang Given the changes in this PR should `BrokerMeter.RESOURCE_MISSING_EXCEPTIONS` still be used here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org