snleee opened a new issue #6785:
URL: https://github.com/apache/incubator-pinot/issues/6785


   We had the major code change in the UI (#5684) and this PR removed all the 
bundled javascript/css files. We keep the separate `LICENSE`, `LICENSE-binary` 
files. `LICENSE` file will be included to the source code distribution while 
`LICENSE-binary` will be included in binary disbution.
   
   I think that we need the following changes:
   
   1. Clean up `LICENSE` and `LICENSE-binary`
   Current `LICENSE` file includes all the dependencies for the new UI webapp, 
which is defined in`pinot-controller/src/main/resources/package.json`. However, 
we actually do not need to include those for our source code distribution 
(because those dependencies will be pulled when compiling the source code). So, 
we don't need to include those in `LICENSE`. On the other hand, we will need 
those for the binary distribution (`LICENSE-binary`) if we ship those 
javascript/css files in our binary distribution tarball.
   2. Clean up `/licenses` and `/licenses-binary` to accommodate the changes 
from the step 1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to