This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3028055 Fix quick-start tests (#6751)
3028055 is described below
commit 30280552f5f4973ff0e4a0451990c469e9992a9f
Author: Xiaotian (Jackie) Jiang <17555551+jackie-ji...@users.noreply.github.com>
AuthorDate: Thu Apr 8 23:38:29 2021 -0700
Fix quick-start tests (#6751)
The connection timeout is caused by using
`InetAddress.getLocalHost().getHostName()` as the local host name, and somehow
github actions vm cannot resolve the host name properly.
---
.github/workflows/scripts/.pinot_quickstart.sh | 18 +++++++++++++-----
pinot-tools/pom.xml | 21 +++++++--------------
.../pinot/tools/admin/command/QuickstartRunner.java | 8 +++-----
3 files changed, 23 insertions(+), 24 deletions(-)
diff --git a/.github/workflows/scripts/.pinot_quickstart.sh
b/.github/workflows/scripts/.pinot_quickstart.sh
index 3f84594..d0bc48c 100755
--- a/.github/workflows/scripts/.pinot_quickstart.sh
+++ b/.github/workflows/scripts/.pinot_quickstart.sh
@@ -39,13 +39,16 @@ if [ "${PASS}" != 1 ]; then
fi
# Quickstart
-DIST_BIN_DIR=`ls -d pinot-distribution/target/apache-pinot-*/apache-pinot-*`
+DIST_BIN_DIR=`ls -d
pinot-distribution/target/apache-pinot-*/apache-pinot-*`/bin
cd "${DIST_BIN_DIR}"
# Test quick-start-batch
-bin/quick-start-batch.sh &
+./quick-start-batch.sh &
PID=$!
+# Print the JVM settings
+jps -lvm
+
PASS=0
# Wait for 1 minute for table to be set up, then at most 5 minutes to reach
the desired state
@@ -82,9 +85,12 @@ if [ "${PASS}" -eq 0 ]; then
fi
# Test quick-start-batch-with-minion
-bin/quick-start-batch-with-minion.sh &
+./quick-start-batch-with-minion.sh &
PID=$!
+# Print the JVM settings
+jps -lvm
+
PASS=0
# Wait for 1 minute for table to be set up, then at most 5 minutes to reach
the desired state
@@ -109,7 +115,7 @@ if [ "${PASS}" -eq 0 ]; then
fi
# Test quick-start-streaming
-bin/quick-start-streaming.sh &
+./quick-start-streaming.sh &
PID=$!
PASS=0
@@ -146,10 +152,12 @@ if [ "${PASS}" -eq 0 ]; then
fi
# Test quick-start-hybrid
-cd bin
./quick-start-hybrid.sh &
PID=$!
+# Print the JVM settings
+jps -lvm
+
PASS=0
RES_1=0
diff --git a/pinot-tools/pom.xml b/pinot-tools/pom.xml
index 6cf0767..3b3afda 100644
--- a/pinot-tools/pom.xml
+++ b/pinot-tools/pom.xml
@@ -312,8 +312,7 @@
<mainClass>org.apache.pinot.tools.Quickstart</mainClass>
<name>quick-start-batch</name>
<jvmSettings>
- <initialMemorySize>1G</initialMemorySize>
- <maxMemorySize>1G</maxMemorySize>
+ <initialMemorySize>4G</initialMemorySize>
<extraArguments>
<extraArgument>-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml</extraArgument>
</extraArguments>
@@ -323,8 +322,7 @@
<mainClass>org.apache.pinot.tools.HybridQuickstart</mainClass>
<name>quick-start-hybrid</name>
<jvmSettings>
- <initialMemorySize>1G</initialMemorySize>
- <maxMemorySize>1G</maxMemorySize>
+ <initialMemorySize>4G</initialMemorySize>
<extraArguments>
<extraArgument>-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml</extraArgument>
</extraArguments>
@@ -334,8 +332,7 @@
<mainClass>org.apache.pinot.tools.RealtimeQuickStart</mainClass>
<name>quick-start-streaming</name>
<jvmSettings>
- <initialMemorySize>1G</initialMemorySize>
- <maxMemorySize>1G</maxMemorySize>
+ <initialMemorySize>4G</initialMemorySize>
<extraArguments>
<extraArgument>-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml</extraArgument>
</extraArguments>
@@ -345,8 +342,7 @@
<mainClass>org.apache.pinot.tools.BatchQuickstartWithMinion</mainClass>
<name>quick-start-batch-with-minion</name>
<jvmSettings>
- <initialMemorySize>1G</initialMemorySize>
- <maxMemorySize>1G</maxMemorySize>
+ <initialMemorySize>4G</initialMemorySize>
<extraArguments>
<extraArgument>-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml</extraArgument>
</extraArguments>
@@ -356,8 +352,7 @@
<mainClass>org.apache.pinot.tools.UpsertQuickStart</mainClass>
<name>quick-start-upsert-streaming</name>
<jvmSettings>
- <initialMemorySize>1G</initialMemorySize>
- <maxMemorySize>1G</maxMemorySize>
+ <initialMemorySize>4G</initialMemorySize>
<extraArguments>
<extraArgument>-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml</extraArgument>
</extraArguments>
@@ -367,8 +362,7 @@
<mainClass>org.apache.pinot.tools.JsonIndexQuickStart</mainClass>
<name>quick-start-json-index-batch</name>
<jvmSettings>
- <initialMemorySize>1G</initialMemorySize>
- <maxMemorySize>1G</maxMemorySize>
+ <initialMemorySize>4G</initialMemorySize>
<extraArguments>
<extraArgument>-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml</extraArgument>
</extraArguments>
@@ -378,8 +372,7 @@
<mainClass>org.apache.pinot.tools.RealtimeJsonIndexQuickStart</mainClass>
<name>quick-start-json-index-streaming</name>
<jvmSettings>
- <initialMemorySize>1G</initialMemorySize>
- <maxMemorySize>1G</maxMemorySize>
+ <initialMemorySize>4G</initialMemorySize>
<extraArguments>
<extraArgument>-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml</extraArgument>
</extraArguments>
diff --git
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
index f3ae041..9d07aed 100644
---
a/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
+++
b/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
@@ -25,7 +25,6 @@ import java.io.File;
import java.io.FileReader;
import java.io.IOException;
import java.io.Reader;
-import java.net.InetAddress;
import java.net.URL;
import java.util.ArrayList;
import java.util.List;
@@ -33,7 +32,6 @@ import java.util.Map;
import java.util.Random;
import org.apache.commons.io.FileUtils;
import org.apache.pinot.common.utils.CommonConstants;
-import org.apache.pinot.core.auth.BasicAuthUtils;
import org.apache.pinot.spi.config.table.TableType;
import org.apache.pinot.spi.config.tenant.TenantRole;
import org.apache.pinot.spi.env.PinotConfiguration;
@@ -41,8 +39,8 @@ import org.apache.pinot.spi.filesystem.PinotFSFactory;
import org.apache.pinot.spi.ingestion.batch.IngestionJobLauncher;
import org.apache.pinot.spi.ingestion.batch.spec.SegmentGenerationJobSpec;
import org.apache.pinot.spi.utils.JsonUtils;
-import org.apache.pinot.tools.QuickstartTableRequest;
import org.apache.pinot.tools.BootstrapTableTool;
+import org.apache.pinot.tools.QuickstartTableRequest;
import org.apache.pinot.tools.utils.JarUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -205,8 +203,8 @@ public class QuickstartRunner {
public void bootstrapTable()
throws Exception {
for (QuickstartTableRequest request : _tableRequests) {
- if (!new BootstrapTableTool("http",
InetAddress.getLocalHost().getHostName(), _controllerPorts.get(0),
- request.getBootstrapTableDir(), _authToken).execute()) {
+ if (!new BootstrapTableTool("http", "localhost",
_controllerPorts.get(0), request.getBootstrapTableDir(),
+ _authToken).execute()) {
throw new RuntimeException("Failed to bootstrap table with request - "
+ request);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
