Jackie-Jiang commented on a change in pull request #6762:
URL: https://github.com/apache/incubator-pinot/pull/6762#discussion_r610169601
##########
File path: .github/workflows/pinot_tests.yml
##########
@@ -85,4 +85,6 @@ jobs:
with:
java-version: ${{ matrix.java }}
- name: Quickstart on JDK ${{ matrix.java }}
+ env:
+ JAVA_OPTS: "-Xms2G
-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml"
Review comment:
Do you think the jvm settings are not correctly picked up from the pom
file?
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/QuickstartRunner.java
##########
@@ -204,11 +209,30 @@ public void createBrokerTenantWith(int number, String
tenantName)
public void bootstrapTable()
throws Exception {
- for (QuickstartTableRequest request : _tableRequests) {
- if (!new BootstrapTableTool("http",
InetAddress.getLocalHost().getHostName(), _controllerPorts.get(0),
- request.getBootstrapTableDir(), _authToken).execute()) {
- throw new RuntimeException("Failed to bootstrap table with request - "
+ request);
+ ExecutorService executorService = Executors.newCachedThreadPool();
Review comment:
I feel the retry might not be needed, and won't really help if the
controller stuck. Adding another executor will add more overhead to the CPU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
