[incubator-pinot] branch master updated: Add more logging for segment reloading status. (#6754)

[tingchen]

This is an automated email from the ASF dual-hosted git repository.

tingchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 25bd754  Add more logging for segment reloading status. (#6754)
25bd754 is described below

commit 25bd7547e4edea62c00ee4b2d7a1fa3d8bdf2943
Author: Ting Chen <tingc...@uber.com>
AuthorDate: Thu Apr 8 09:39:10 2021 -0700

    Add more logging for segment reloading status. (#6754)
    
    * Add more logging for debugging segment reloading.
    
    * Update 
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/SegmentPreProcessor.java
    
    Co-authored-by: Xiaotian (Jackie) Jiang 
<17555551+jackie-ji...@users.noreply.github.com>
    
    * Update 
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/SegmentPreProcessor.java
    
    Co-authored-by: Xiaotian (Jackie) Jiang 
<17555551+jackie-ji...@users.noreply.github.com>
    
    * Revised based on comments.
    
    Co-authored-by: Xiaotian (Jackie) Jiang 
<17555551+jackie-ji...@users.noreply.github.com>
---
 .../apache/pinot/core/segment/index/loader/SegmentPreProcessor.java    | 3 +++
 1 file changed, 3 insertions(+)

diff --git 
a/pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/SegmentPreProcessor.java
 
b/pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/SegmentPreProcessor.java
index 97fb2b7..1aa4d77 100644
--- 
a/pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/SegmentPreProcessor.java
+++ 
b/pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/SegmentPreProcessor.java
@@ -81,6 +81,7 @@ public class SegmentPreProcessor implements AutoCloseable {
   public void process()
       throws Exception {
     if (_segmentMetadata.getTotalDocs() == 0) {
+      LOGGER.info("Skip preprocessing empty segment: {}", 
_segmentMetadata.getName());
       return;
     }
     // Remove all the existing inverted index temp files before loading 
segments.
@@ -104,6 +105,8 @@ public class SegmentPreProcessor implements AutoCloseable {
         defaultColumnHandler.updateDefaultColumns();
         _segmentMetadata = new SegmentMetadataImpl(_indexDir);
         _segmentDirectory.reloadMetadata();
+      } else {
+        LOGGER.warn("Skip creating default columns for segment: {} without 
schema", _segmentMetadata.getName());
       }
 
       // Create column inverted indices according to the index config.

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org