Jackie-Jiang commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r606584788
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -383,7 +383,12 @@
public static class Segment {
public static class Realtime {
public enum Status {
- IN_PROGRESS, DONE
+ // Means the segment is not completed and still consuming stream data
+ IN_PROGRESS,
+ // Means the segment is completed and sealed by some Pinot server and
uploaded
+ DONE,
+ // Means the segment is uploaded to a Pinot controller by an external
party
+ UPLOADED
Review comment:
I feel `CONSUMING` and `COMPLETED` is more clear, and consistent with
the term we used in the segment assignment strategy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
