mcvsubbu commented on a change in pull request #6742:
URL: https://github.com/apache/incubator-pinot/pull/6742#discussion_r606455268
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java
##########
@@ -30,22 +30,8 @@
* Data table is used to transfer data from server to broker.
*/
public interface DataTable {
+ // TODO: remove this when we stop supporting DataTable V2.
String EXCEPTION_METADATA_KEY = "Exception";
- String NUM_DOCS_SCANNED_METADATA_KEY = "numDocsScanned";
Review comment:
Before removing these, please make sure and double-check that these are
the exact strings (with no typos) used in `MetadataKeys`. I think some of these
are returned in the results metadata by broker? We should take care not to
break compat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
