jackjlli commented on a change in pull request #6691:
URL: https://github.com/apache/incubator-pinot/pull/6691#discussion_r605425443
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java
##########
@@ -45,13 +45,13 @@ public void setUp()
// Start the Pinot cluster
Review comment:
// Start zookeeper
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/ControllerTestUtils.java
##########
@@ -201,7 +204,14 @@ public static ControllerConf getControllerConfig() {
}
public static void stopController() {
- _controllerStarter.stop();
+ try {
+ ExecutorService executor = Executors.newCachedThreadPool();
+ executor.submit(() -> _controllerStarter.stop());
+ executor.shutdown();
+ executor.awaitTermination(30, TimeUnit.SECONDS);
Review comment:
Is it worthy to stop for 30 seconds?
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java
##########
@@ -45,13 +45,13 @@ public void setUp()
// Start the Pinot cluster
startZk();
+ // Start Kafka
+ startKafka();
+
startController();
Review comment:
// Start pinot components
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/LuceneRealtimeClusterIntegrationTest.java
##########
@@ -112,12 +112,12 @@ public void setUp()
// Start the Pinot cluster
startZk();
- startController();
- startBroker();
- startServer();
// Start Kafka
startKafka();
+ startController();
Review comment:
Why do we move all the pinot components after starting kafka?
If there is a reason, could you update the comments above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
