mqliang opened a new issue #6720: URL: https://github.com/apache/incubator-pinot/issues/6720
As pointed at: https://github.com/apache/incubator-pinot/blob/e892cb2942f1f41ac7056d977eeca0e5b22897d0/pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java#L77 Currently, `setColumn()` use rowId&colId to first locate the offset of ByteBuffer, the write the actual value to the offset. This allowed us to set the value for a given colId, but have a lot of overhead of calling `ByteBuffer.position()`. In practice, we often build a data table row in a bulk way, which means we can write all values of a row one by one, without calling `ByteBuffer.position()` for each column. We need to benchmark those two approaches (it's possible that the overhead of calling `ByteBuffer.position()` is negligible). If the bulk way is better, will send a PR to address it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
