siddharthteotia commented on pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#issuecomment-806259380
> > @siddharthteotia , @mqliang and I met, and agreed on the following (I have added some extras, so take a look) > > > > * We will move the metadata to the trailer, retain the other elements in the same order. > > * We will encode the trailer as > > * = (int, int, blob)+ > > * The first int is the enum ordinal, second int is the length of the blob, the third part is utf8 encoding of a string, or int/long as dictated by the enum. If int/long, then we will encode in network byte order (big-endian). Alternative is to convert it to a string. > > Not sure which option @siddharthteotia agrees with, but the alternatives are something like: > `7, 8, "12609856"` (8 byte string for a number) > vs > `7, 4, 12609856` (4-byte integer for a number) > > Maybe we can decide based on what looks easier in code. @mcvsubbu I agree with the big endian approach in case when the value/blob part itself is fixed with int or long -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
