liuchang0520 commented on a change in pull request #6653: URL: https://github.com/apache/incubator-pinot/pull/6653#discussion_r598475935
########## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManagerConfig.java ########## @@ -50,6 +50,8 @@ public static final String INSTANCE_SEGMENT_TAR_DIR = "segmentTarDir"; // Key of segment directory public static final String INSTANCE_BOOTSTRAP_SEGMENT_DIR = "bootstrap.segment.dir"; + // Key of segment store uri + public static final String SEGMENT_STORE_URI = "segment.store.uri"; Review comment: Since import HelixInstanceDataManagerConfig's "segment.store.uri" would cause circular dependency between pinot-server and pinot-core, I added this config key to CommonConstants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org