npawar commented on a change in pull request #6667:
URL: https://github.com/apache/incubator-pinot/pull/6667#discussion_r595589572
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -161,6 +163,48 @@ public boolean getIsSplitCommitEnabled() {
return _controllerConf.getAcceptSplitCommit();
}
+ /**
+ * Using the ideal state and segment metadata, return a list of {@link
PartitionGroupMetadata}
+ * for latest segment of each partition group
+ */
+ public List<PartitionGroupMetadata>
getCurrentPartitionGroupMetadataList(IdealState idealState,
Review comment:
This should still be currentPartitionGroupMetadata. It is only using the
latest segment zk metadata, but it represents the current state of the
partition groups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
