mcvsubbu commented on a change in pull request #6684:
URL: https://github.com/apache/incubator-pinot/pull/6684#discussion_r595404025
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
##########
@@ -78,9 +80,11 @@ public static SegmentBuildTimeLeaseExtender
getOrCreate(final String instanceId,
ServerMetrics serverMetrics, String tableNameWithType) {
return TABLE_TO_LEASE_EXTENDER.compute(tableNameWithType, (k, v) -> {
if (v == null) {
- return new SegmentBuildTimeLeaseExtender(instanceId, serverMetrics,
tableNameWithType);
+ SegmentBuildTimeLeaseExtender leaseExtender = new
SegmentBuildTimeLeaseExtender(instanceId, serverMetrics, tableNameWithType);
+ LOGGER.info("Created lease extender for table: {}", tableNameWithType);
+ return leaseExtender;
} else {
- LOGGER.warn("Lease extender for Table: {} already exists",
tableNameWithType);
+ LOGGER.info("Lease extender for table: {} already exists",
tableNameWithType);
Review comment:
For now that may be the case, but it is not erroneous to get a handle to
the lease extender in some other place, if we want to. I suggest to leave it as
info, but I will be flexible there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
