npawar commented on a change in pull request #6664: URL: https://github.com/apache/incubator-pinot/pull/6664#discussion_r592801736
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/batch/spec/SegmentGenerationJobSpec.java ########## @@ -121,6 +121,8 @@ */ private TlsSpec _tlsSpec; + private boolean _failOnEmptySegment = false; Review comment: can you add a comment on this (similar to the other fields in this file)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org